lukasz-antoniak commented on code in PR #110:
URL:
https://github.com/apache/cassandra-analytics/pull/110#discussion_r2174559338
##########
cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/utils/streaming/BufferingInputStream.java:
##########
@@ -346,24 +361,28 @@ else if (count <= bytesBuffered())
* @param buffer the ByteBuffer
* @throws EOFException if attempts to read beyond the end of the file
* @throws IOException for failure during I/O
+ * @return number of bytes read
*/
- public void read(ByteBuffer buffer) throws IOException
+ public int read(ByteBuffer buffer) throws IOException
{
+ int read = 0; // Cassandra 4.x vs 5.x
Review Comment:
Correct, just a temporal marker. Wanted to indicate that we are returning
now number of bytes read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
