[ https://issues.apache.org/jira/browse/CASSANALYTICS-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17986901#comment-17986901 ]
Stefan Miklosovic commented on CASSANALYTICS-66: ------------------------------------------------ I am not completely sure what's up with the failures. One is a timeout. For another one all tests passed but it just errors on some infra code? https://app.circleci.com/pipelines/github/smiklosovic/cassandra-analytics/16/workflows/74124a5e-3efb-4692-aa5a-23a1ea441032 > Replace org.jetbrains.annotations.NotNull > ------------------------------------------ > > Key: CASSANALYTICS-66 > URL: https://issues.apache.org/jira/browse/CASSANALYTICS-66 > Project: Apache Cassandra Analytics > Issue Type: Task > Reporter: Stefan Miklosovic > Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Is there some important reason why these annotations are used? When I copy > some class with them to new project, they are not found. Is this because the > project is developed in IntelliJ IDEA most often and there is some support > for that in IDE itself when something might be null and so on? > I do not think we should be biased towards one IDE in the code. > Based on this (1) all of these annotations are recognized by IDEA. I think we > should use something like javax.annotations.(Nullable|Nonnull) to be the most > neutral possible. > (1) > https://www.jetbrains.com/help/idea/annotating-source-code.html#default_nullability_annotations -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org