[ 
https://issues.apache.org/jira/browse/CASSANDRA-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146555#comment-13146555
 ] 

Jonathan Ellis commented on CASSANDRA-3474:
-------------------------------------------

(The problem is that usesHistogramAndReplayPositionStatsFile is actually the 
opposite of what the name implies.  It also checks the wrong Descriptor version 
which is weird.  Finally, there's a bunch of duplicated code.)
                
> SSTableMetadata deserialization works but looks broken
> ------------------------------------------------------
>
>                 Key: CASSANDRA-3474
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3474
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Jonathan Ellis
>            Priority: Minor
>             Fix For: 1.0.3
>
>
> This is confusing:
> {code}
> .               if (!descriptor.usesHistogramAndReplayPositionStatsFile)
>                   return deserialize(dis); // deserializes histogram
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to