[
https://issues.apache.org/jira/browse/CASSANDRA-20827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18019452#comment-18019452
]
Stefan Miklosovic commented on CASSANDRA-20827:
-----------------------------------------------
[~mrktsm] thank you for the changes! I am sorry I am being so pedantic but we
also need to add a test which will test both unset and set system property and
format in each case.
Try to follow this example (1). WithProperties sets system property. The reason
it is wrapped in try-catch is that WithProperties implements AutoCloseable so
after try-catch, the property is cleared - it is set back to what it was
before. That way we can test the state of system properties and it is cleaned
up automatically.
https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/db/commitlog/CommitLogTest.java#L356
> Represent complex settings as JSON on system_views.settings table
> -----------------------------------------------------------------
>
> Key: CASSANDRA-20827
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20827
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: Local/Config
> Reporter: Paulo Motta
> Assignee: Marko Tsymbaliuk
> Priority: Normal
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Complex configuration (maps/sets/lists) are represented as
> Collections.toString() on {{system.settings}} virtual table:
> {code:java}
> cqlsh> select * from system_views.settings where name='seed_provider' ;
> name | value
> ------+-------
> (0 rows)
> cqlsh> select * from system_views.settings where
> name='seed_provider.parameters' ;
> name | value
> --------------------------+------------------------
> seed_provider.parameters | {seeds=127.0.0.1:7000}
> {code}
> While this is fine for human consumption, it's not ideal for programmatic
> access, since it requires custom parsing.
> This ticket is to add ability of representing complex types as JSON on
> {{system.settings}} and potentially making it default in trunk, so the above
> would return:
> {code:java}
> cqlsh> select * from system_views.settings where name='seed_provider' ;
> name | value
> ------+-------
> (0 rows)
> cqlsh> select * from system_views.settings where
> name='seed_provider.parameters' ;
> name | value
> --------------------------+------------------------
> seed_provider.parameters | {"seeds": "127.0.0.1:7000"}{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
