frankgh commented on code in PR #140:
URL:
https://github.com/apache/cassandra-analytics/pull/140#discussion_r2356934486
##########
cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/data/CqlTable.java:
##########
@@ -43,6 +44,34 @@ public class CqlTable implements Serializable
{
private static final long serialVersionUID = 1018995207366817661L;
+ public enum TableProperty
+ {
+ CDC("cdc"),
Review Comment:
I think we should match this to
`org.apache.cassandra.spark.utils.CqlUtils#TABLE_PROPERTY_OVERRIDE_ALLOWLIST`
because we are bounded to the table property override list. Also, we should
really test this to make sure this works when we are parsing the CQL statement
and converting that to a CqlTable, like we do in `CassandraDataLayer`
```
String createStmt = CqlUtils.extractTableSchema(fullSchema,
keyspace, table);
....
cqlTable = bridge().buildSchema(createStmt, keyspace,
replicationFactor, partitioner, udts, null, indexCount, false);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
