[ 
https://issues.apache.org/jira/browse/CASSANDRA-20929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yaniv Kaul updated CASSANDRA-20929:
-----------------------------------
    Description: 
>From 
>[https://github.com/apache/cassandra/blob/e2d2e3b31ba47dfc9bbdbfdbcace3932fd3d32e7/doc/native_protocol_v5.spec#L137-L140]
> :

The variant with LZ4 compression uses an 8 byte header. The first 4 bytes 
contain
  an unsigned integer (little endian) containing the compressed and uncompressed
  lengths of the payload and the self contained flag.

But 
[https://github.com/apache/cassandra/blob/e2d2e3b31ba47dfc9bbdbfdbcace3932fd3d32e7/doc/native_protocol_v5.spec#L144-L146]
 says:

  1. Compressed length            (17 bits)
  2. Uncompressed length          (17 bits)
  3. isSelfContained flag         (1 bit)

 

17 + 17 + 1 are already 35 bits - which is more than 'first 4 bytes' 

 

  was:
>From 
>[https://github.com/apache/cassandra/blob/e2d2e3b31ba47dfc9bbdbfdbcace3932fd3d32e7/doc/native_protocol_v5.spec#L137-L140]
> :

The variant with LZ4 compression uses an 8 byte header. The first 4 bytes 
contain
  an unsigned integer (little endian) containing the compressed and uncompressed
  lengths of the payload and the self contained flag.

But 
[https://github.com/apache/cassandra/blob/e2d2e3b31ba47dfc9bbdbfdbcace3932fd3d32e7/doc/native_protocol_v5.spec#L144-L146]
 says:

  1. Compressed length            (17 bits)
  2. Uncompressed length          (17 bits)
  3. isSelfContained flag         (1 bit)

 

17 + 17 + 1 is already 35 bytes - which is more than 'first 4 bytes' 

 


> Protocol v5 spec is wrong - wrt compressed frame format
> -------------------------------------------------------
>
>                 Key: CASSANDRA-20929
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-20929
>             Project: Apache Cassandra
>          Issue Type: Bug
>            Reporter: Yaniv Kaul
>            Priority: Normal
>
> From 
> [https://github.com/apache/cassandra/blob/e2d2e3b31ba47dfc9bbdbfdbcace3932fd3d32e7/doc/native_protocol_v5.spec#L137-L140]
>  :
> The variant with LZ4 compression uses an 8 byte header. The first 4 bytes 
> contain
>   an unsigned integer (little endian) containing the compressed and 
> uncompressed
>   lengths of the payload and the self contained flag.
> But 
> [https://github.com/apache/cassandra/blob/e2d2e3b31ba47dfc9bbdbfdbcace3932fd3d32e7/doc/native_protocol_v5.spec#L144-L146]
>  says:
>   1. Compressed length            (17 bits)
>   2. Uncompressed length          (17 bits)
>   3. isSelfContained flag         (1 bit)
>  
> 17 + 17 + 1 are already 35 bits - which is more than 'first 4 bytes' 
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to