[ 
https://issues.apache.org/jira/browse/CASSANDRA-21111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18050859#comment-18050859
 ] 

Stefan Miklosovic commented on CASSANDRA-21111:
-----------------------------------------------

Another option is to simply omit the rows into legacy table for which 
generation ids are bigger than Integer.MAX_VALUE. We insert into 
"sstable_activity" table only via {{SystemKeyspace.persistSSTableReadMeter}} 
which just "Writes the current read rates for a given SSTable to 
system.sstable_activity". That is also only triggered when 

{code}
        void maybePersistSSTableReadMeter()
        {
            if (obsoletion == null && 
DatabaseDescriptor.getSStableReadRatePersistenceEnabled())
            {
                meterSyncThrottle.acquire();
                SystemKeyspace.persistSSTableReadMeter(desc.ksname, 
desc.cfname, desc.id, readMeter);
            }
        }
{code}

which is already "maybe" as the method name suggests.

sstable_read_rate_persistence_enabled in Config is by default false already. 

I think it is acceptable to not record anything which would overflow into that 
table. 

> Cassandra sstable generation ID's are a signed int which might overflow
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-21111
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-21111
>             Project: Apache Cassandra
>          Issue Type: Bug
>          Components: Local/SSTable
>            Reporter: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
>
> We need to triage this but this seems to be legit:
> We have hit an issue with a cluster that where sstable generation ID’s for a 
> peer has incremented so high that it has overflowed, which has introduced a 
> 2nd dash into the file name. For example:
> nb--2146021117-big-data.db
> This caused an issue with our solution which is aimed to consolidate 
> partition statistics in the data set. The current version of the solution 
> does not recognise the possibility of sstable generation ID’s being a 
> negative value - which causes it to fail.
> Workaround:
> Rename all sstables in the table to “reset” the generation ID.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to