[ 
https://issues.apache.org/jira/browse/CASSANDRA-21088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18050993#comment-18050993
 ] 

Dmitry Konstantinov commented on CASSANDRA-21088:
-------------------------------------------------

CI test run results: [https://pre-ci.cassandra.apache.org/job/cassandra/299/]

[^CASSANDRA-21088_ci_summary.htm]

[^CASSANDRA-21088_results_details.tar.xz]

All failures are flaky or not related to the changes:
 * [Tests / jvm-dtest jdk11 15/16 / 
org.apache.cassandra.distributed.test.accord.AccordInteroperabilityTest.testNonSerialWriteIsThroughAccordFull-_jdk11_x86_64|https://pre-ci.cassandra.apache.org/job/cassandra/299/testReport/junit/org.apache.cassandra.distributed.test.accord/AccordInteroperabilityTest/Tests___jvm_dtest_jdk11_15_16___testNonSerialWriteIsThroughAccordFull__jdk11_x86_64/]
 * [Tests / jvm-dtest jdk11 11/16 / 
org.apache.cassandra.distributed.test.accord.AccordTimestampPreservationTest.testMutationPreservesTimestamp-_jdk11_x86_64|https://pre-ci.cassandra.apache.org/job/cassandra/299/testReport/junit/org.apache.cassandra.distributed.test.accord/AccordTimestampPreservationTest/Tests___jvm_dtest_jdk11_11_16___testMutationPreservesTimestamp__jdk11_x86_64/]
 * [Tests / jvm-dtest jdk11 13/16 / 
org.apache.cassandra.distributed.test.accord.AccordWriteInteroperabilityTest.testTransactionStatementApplyIsInteropApply[transactionalMode=mixed_reads,
 
migrated=firstPhase]-_jdk11_x86_64|https://pre-ci.cassandra.apache.org/job/cassandra/299/testReport/junit/org.apache.cassandra.distributed.test.accord/AccordWriteInteroperabilityTest/Tests___jvm_dtest_jdk11_13_16___testTransactionStatementApplyIsInteropApply_transactionalMode_mixed_reads__migrated_firstPhase___jdk11_x86_64/]
 * [Tests / jvm-dtest jdk11 9/16 / 
org.apache.cassandra.distributed.test.cql3.MixedReadsAccordInteropMultiNodeTableWalkTest.test-_jdk11_x86_64|https://pre-ci.cassandra.apache.org/job/cassandra/299/testReport/junit/org.apache.cassandra.distributed.test.cql3/MixedReadsAccordInteropMultiNodeTableWalkTest/Tests___jvm_dtest_jdk11_9_16___test__jdk11_x86_64/]
 * [Tests / test jdk11 13/20 / 
org.apache.cassandra.net.ConnectionTest.testMessageDeliveryOnReconnect-_jdk11_x86_64|https://pre-ci.cassandra.apache.org/job/cassandra/299/testReport/junit/org.apache.cassandra.net/ConnectionTest/Tests___test_jdk11_13_20___testMessageDeliveryOnReconnect__jdk11_x86_64/]
 * [Tests / dtest-latest jdk11 14/64 / 
dtest-latest.bootstrap_test.TestBootstrap.test_killed_wiped_node_cannot_join|https://pre-ci.cassandra.apache.org/job/cassandra/299/testReport/junit/dtest-latest.bootstrap_test/TestBootstrap/Tests___dtest_latest_jdk11_14_64___test_killed_wiped_node_cannot_join/]
 * [Tests / dtest jdk11 13/64 / 
dtest.bootstrap_test.TestBootstrap.test_shutdown_wiped_node_cannot_join|https://pre-ci.cassandra.apache.org/job/cassandra/299/testReport/junit/dtest.bootstrap_test/TestBootstrap/Tests___dtest_jdk11_13_64___test_shutdown_wiped_node_cannot_join/]
 * [Tests / jvm-dtest jdk11 5/16 / 
org.apache.cassandra.distributed.test.accord.MigrationFromAccordWriteRaceTest.testSplitAndRetryNonSerialLoggedBatchTwoTablesTwoPkeyHintedViaBatchLogRoutingFailure-_jdk11_x86_64|https://pre-ci.cassandra.apache.org/job/cassandra/299/testReport/junit/org.apache.cassandra.distributed.test.accord/MigrationFromAccordWriteRaceTest/Tests___jvm_dtest_jdk11_5_16___testSplitAndRetryNonSerialLoggedBatchTwoTablesTwoPkeyHintedViaBatchLogRoutingFailure__jdk11_x86_64/]
 * [Tests / simulator-dtest jdk11 1/2 / 
org.apache.cassandra.simulator.test.ShortAccordSimulationTest.simulationTest-_jdk11_x86_64|https://pre-ci.cassandra.apache.org/job/cassandra/299/testReport/junit/org.apache.cassandra.simulator.test/ShortAccordSimulationTest/Tests___simulator_dtest_jdk11_1_2___simulationTest__jdk11_x86_64/]
 * [Tests / jvm-dtest jdk11 5/16 / 
junit.framework.TestSuite.org.apache.cassandra.distributed.test.accord.MigrationFromAccordWriteRaceTest-_jdk11_x86_64|https://pre-ci.cassandra.apache.org/job/cassandra/299/testReport/junit/junit.framework/TestSuite/Tests___jvm_dtest_jdk11_5_16___org_apache_cassandra_distributed_test_accord_MigrationFromAccordWriteRaceTest__jdk11_x86_64/]
 * [Tests / jvm-dtest jdk11 3/16 / 
org.apache.cassandra.fuzz.topology.AccordBootstrapTest.terminated 
successfully-cassandra.testtag_IS_UNDEFINED|https://pre-ci.cassandra.apache.org/job/cassandra/299/testReport/junit/org.apache.cassandra.fuzz.topology/AccordBootstrapTest/Tests___jvm_dtest_jdk11_3_16___terminated_successfully_cassandra_testtag_IS_UNDEFINED/]
 * [Tests / simulator-dtest jdk11 2/2 / 
org.apache.cassandra.simulator.test.ShortPaxosSimulationTest.selfReconcileTest-cassandra.testtag_IS_UNDEFINED|https://pre-ci.cassandra.apache.org/job/cassandra/299/testReport/junit/org.apache.cassandra.simulator.test/ShortPaxosSimulationTest/Tests___simulator_dtest_jdk11_2_2___selfReconcileTest_cassandra_testtag_IS_UNDEFINED/]

 

> Minor perf optimizations around memtable put logic
> --------------------------------------------------
>
>                 Key: CASSANDRA-21088
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-21088
>             Project: Apache Cassandra
>          Issue Type: Improvement
>          Components: Local/Memtable
>            Reporter: Dmitry Konstantinov
>            Assignee: Dmitry Konstantinov
>            Priority: Normal
>             Fix For: 5.1
>
>         Attachments: CASSANDRA-21088.html, CASSANDRA-21088_ci_summary.htm, 
> CASSANDRA-21088_results_details.tar.xz, memtable_after_v2_alloc.html, 
> memtable_after_v2_cpu.html, memtable_before_alloc.html, 
> memtable_before_cpu.html
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> * Avoid BTree iterators allocation in ColumnsCollector.update (0.3% of 
> allocations)
>  * reduce amount of virtual calls within Cell.dataSize (Cell.dataSize costs 
> 1.62 % of CPU)
>  * avoid capturing lambda allocation in BTreeRow.clone (0.59% of allocations)
>  * Do not recalculate minLocalDeletionTime when BTreeRow is cloned (0.37 % of 
> CPU)
> allocation/CPU are taken from profile data for batch write test ( 
> CASSANDRA-20226 )



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to