[
https://issues.apache.org/jira/browse/CASSANDRA-21182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sam Lightfoot updated CASSANDRA-21182:
--------------------------------------
Description:
Flakiness indicating more than 64MB of direct pool growth between stress tests
{code:java}
# Now run the full stack to warm up internal caches/pools
LARGE_COLUMN_SIZE = 1024 * 1024 * 63
self.stress_with_col_size(cluster, node1, LARGE_COLUMN_SIZE)
after1stLargeStress = self.directbytes(node1)
logger.info("After 1st large column stress, direct memory:
{0}".format(after1stLargeStress))
# Now run the full stack to see how much memory is allocated for the second
"large" columns request
self.stress_with_col_size(cluster, node1, LARGE_COLUMN_SIZE)
after2ndLargeStress = self.directbytes(node1)
logger.info("After 2nd large column stress, direct memory:
{0}".format(after2ndLargeStress))
# We may allocate direct memory proportional to size of a request
# but we want to ensure that when we do subsequent calls the used direct memory
is not growing
diff = int(after2ndLargeStress) - int(after1stLargeStress)
logger.info("Direct memory delta: {0}".format(diff))
assert diff < LARGE_COLUMN_SIZE {code}
[https://pre-ci.cassandra.apache.org/job/cassandra/410/testReport/junit/dtest.largecolumn_test/TestLargeColumn/Tests___dtest_jdk21_34_64___test_cleanup/history/]
{code:java}
assert 66073403 < 66060288 {code}
This could be a real issue - this amount of growth is unexpected.
was:
The test asserts memory has not grown on subsequent allocations, but gives no
tolerance for background allocations, and thus often fails because the
assertion is a few kb out of bounds.
Given we're asserting 64MB of growth has not happened, we can add a percentage
delta allowance to the assertion.
[https://pre-ci.cassandra.apache.org/job/cassandra/410/testReport/junit/dtest.largecolumn_test/TestLargeColumn/Tests___dtest_jdk21_34_64___test_cleanup/history/]
{code:java}
assert 66073403 < 66060288 {code}
> Fix flaky DTest: largecolumn_test.TestLargeColumn
> -------------------------------------------------
>
> Key: CASSANDRA-21182
> URL: https://issues.apache.org/jira/browse/CASSANDRA-21182
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Local/Compaction
> Reporter: Sam Lightfoot
> Assignee: Sam Lightfoot
> Priority: Normal
> Fix For: 5.1
>
>
> Flakiness indicating more than 64MB of direct pool growth between stress tests
> {code:java}
> # Now run the full stack to warm up internal caches/pools
> LARGE_COLUMN_SIZE = 1024 * 1024 * 63
> self.stress_with_col_size(cluster, node1, LARGE_COLUMN_SIZE)
> after1stLargeStress = self.directbytes(node1)
> logger.info("After 1st large column stress, direct memory:
> {0}".format(after1stLargeStress))
> # Now run the full stack to see how much memory is allocated for the second
> "large" columns request
> self.stress_with_col_size(cluster, node1, LARGE_COLUMN_SIZE)
> after2ndLargeStress = self.directbytes(node1)
> logger.info("After 2nd large column stress, direct memory:
> {0}".format(after2ndLargeStress))
> # We may allocate direct memory proportional to size of a request
> # but we want to ensure that when we do subsequent calls the used direct
> memory is not growing
> diff = int(after2ndLargeStress) - int(after1stLargeStress)
> logger.info("Direct memory delta: {0}".format(diff))
> assert diff < LARGE_COLUMN_SIZE {code}
> [https://pre-ci.cassandra.apache.org/job/cassandra/410/testReport/junit/dtest.largecolumn_test/TestLargeColumn/Tests___dtest_jdk21_34_64___test_cleanup/history/]
> {code:java}
> assert 66073403 < 66060288 {code}
> This could be a real issue - this amount of growth is unexpected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
