[ https://issues.apache.org/jira/browse/CASSANDRA-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-1034: ---------------------------------------- Attachment: 0003-unit-test-v3.patch 0002-Remove-assumption-that-token-and-keys-are-one-to-one-v3.patch 0001-Generify-AbstractBounds-v3.patch Attaching v3, rebased and using an enum for the RowPosition kind. I could have changed a few {{assert key instanceof DecoratedKey}} by {{assert key.kind() == RowPosition.Kind.ROW_KEY}} I suppose, but I prefered keeping the instanceof since each time the next line do a cast to DK, so this feels more coherent like that. > Remove assumption that Key to Token is one-to-one > ------------------------------------------------- > > Key: CASSANDRA-1034 > URL: https://issues.apache.org/jira/browse/CASSANDRA-1034 > Project: Cassandra > Issue Type: Bug > Reporter: Stu Hood > Assignee: Sylvain Lebresne > Priority: Minor > Fix For: 1.1 > > Attachments: 0001-Generify-AbstractBounds-v2.patch, > 0001-Generify-AbstractBounds-v3.patch, 0001-Generify-AbstractBounds.patch, > 0002-Remove-assumption-that-token-and-keys-are-one-to-one-v2.patch, > 0002-Remove-assumption-that-token-and-keys-are-one-to-one-v3.patch, > 0002-Remove-assumption-that-token-and-keys-are-one-to-one.patch, > 0003-unit-test-v2.patch, 0003-unit-test-v3.patch, 0003-unit-test.patch, > 1034_v1.txt, CASSANDRA-1034.patch > > > get_range_slices assumes that Tokens do not collide and converts a KeyRange > to an AbstractBounds. For RandomPartitioner, this assumption isn't safe, and > would lead to a very weird heisenberg. > Converting AbstractBounds to use a DecoratedKey would solve this, because the > byte[] key portion of the DecoratedKey can act as a tiebreaker. > Alternatively, we could make DecoratedKey extend Token, and then use > DecoratedKeys in places where collisions are unacceptable. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira