jmckenzie-dev commented on code in PR #192:
URL:
https://github.com/apache/cassandra-analytics/pull/192#discussion_r3065956311
##########
cassandra-analytics-integration-framework/src/main/java/org/apache/cassandra/sidecar/testing/SharedClusterIntegrationTestBase.java:
##########
@@ -188,6 +189,12 @@ protected void setup() throws Exception
beforeClusterProvisioning();
cluster = provisionClusterWithRetries(this.testVersion);
assertThat(cluster).isNotNull();
+ // If we have a test timeout, we'll often get a wall of FSWriteErrors
inside tmp files as memtable flushing
+ // and transaction log I/O races w/shutdowns from our tests here.
Rather than get extra insult to injury if a
+ // test times out, we instead unregister the StorageService shutdown
hooks; we don't much care about memtable
+ // content from a node getting flushed with unit tests that run
ephemerally.
+ // If in the future we start to rely on stopping and starting C* nodes
and the StorageService shutdown hooks
Review Comment:
... I don't have this on my local branch. But I DID have a couple other
revisions locally I apparently forgot to push. 🤦🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
