[
https://issues.apache.org/jira/browse/CASSSIDECAR-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18083762#comment-18083762
]
Stefan Miklosovic commented on CASSSIDECAR-447:
-----------------------------------------------
I was thinking this will solve CASSSIDECAR-418 which is sadly not true.
> Scope all CDC dependencies exclusively to CdcModule
> -----------------------------------------------------
>
> Key: CASSSIDECAR-447
> URL: https://issues.apache.org/jira/browse/CASSSIDECAR-447
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: CDC
> Reporter: Yifan Cai
> Assignee: Yifan Cai
> Priority: Major
> Fix For: 0.4.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Many CDC classes are annotated with both @Singleton and @Inject is
> JIT-bindable by Guice regardless of whether its owning module is installed.
> This meant all CDC singletons could be created even when CDC was disabled,
> simply by being injected as a transitive dependency.
> Proposing the patch to properly honor the feature flag, cdc_enabled. If the
> feature flag is disabled, ensuring CDC objects are not instantiated.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
