[ 
https://issues.apache.org/jira/browse/CASSANDRA-21400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18084069#comment-18084069
 ] 

Dmitry Konstantinov edited comment on CASSANDRA-21400 at 5/28/26 10:36 AM:
---------------------------------------------------------------------------

CI run for trunk: https://pre-ci.cassandra.apache.org/job/cassandra/573/
Test failures are known issues not related to the change:
Tests / jvm-dtest jdk17 1/16 / 
org.apache.cassandra.fuzz.topology.AccordTopologyMixupTest.test-_jdk17_x86_64
Tests / jvm-dtest jdk17 4/16 / 
org.apache.cassandra.distributed.test.accord.AccordMigrationTest.testPaxosToAccordCAS-_jdk17_x86_64
Tests / jvm-dtest jdk17 4/16 / 
org.apache.cassandra.distributed.test.accord.AccordMigrationTest.testPaxosToAccordSerialRead-_jdk17_x86_64
Tests / dtest-latest jdk17 7/64 / 
dtest-latest.bootstrap_test.TestBootstrap.test_consistent_range_movement_false_with_rf1_should_succeed
Tests / dtest-latest jdk17 6/64 / 
dtest-latest.bootstrap_test.TestBootstrap.test_consistent_range_movement_true_with_rf1_should_fail
Tests / dtest-latest jdk17 34/64 / 
dtest-latest.client_request_metrics_test.TestClientRequestMetrics.test_client_request_metrics
Tests / dtest-latest jdk17 23/64 / 
dtest-latest.replace_address_test.TestReplaceAddress.test_replace_with_insufficient_replicas
Tests / dtest-latest jdk17 23/64 / 
dtest-latest.replace_address_test.TestReplaceAddress.test_replace_with_insufficient_replicas
Tests / dtest-latest jdk17 23/64 / 
dtest-latest.replace_address_test.TestReplaceAddress.test_replace_with_insufficient_replicas


was (Author: dnk):
CI run: https://pre-ci.cassandra.apache.org/job/cassandra/573/
Test failures are known issues not related to the change:
Tests / jvm-dtest jdk17 1/16 / 
org.apache.cassandra.fuzz.topology.AccordTopologyMixupTest.test-_jdk17_x86_64
Tests / jvm-dtest jdk17 4/16 / 
org.apache.cassandra.distributed.test.accord.AccordMigrationTest.testPaxosToAccordCAS-_jdk17_x86_64
Tests / jvm-dtest jdk17 4/16 / 
org.apache.cassandra.distributed.test.accord.AccordMigrationTest.testPaxosToAccordSerialRead-_jdk17_x86_64
Tests / dtest-latest jdk17 7/64 / 
dtest-latest.bootstrap_test.TestBootstrap.test_consistent_range_movement_false_with_rf1_should_succeed
Tests / dtest-latest jdk17 6/64 / 
dtest-latest.bootstrap_test.TestBootstrap.test_consistent_range_movement_true_with_rf1_should_fail
Tests / dtest-latest jdk17 34/64 / 
dtest-latest.client_request_metrics_test.TestClientRequestMetrics.test_client_request_metrics
Tests / dtest-latest jdk17 23/64 / 
dtest-latest.replace_address_test.TestReplaceAddress.test_replace_with_insufficient_replicas
Tests / dtest-latest jdk17 23/64 / 
dtest-latest.replace_address_test.TestReplaceAddress.test_replace_with_insufficient_replicas
Tests / dtest-latest jdk17 23/64 / 
dtest-latest.replace_address_test.TestReplaceAddress.test_replace_with_insufficient_replicas

> Replace LongAdder in metric-like logic with ThreadLocalCounter
> --------------------------------------------------------------
>
>                 Key: CASSANDRA-21400
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-21400
>             Project: Apache Cassandra
>          Issue Type: Improvement
>          Components: Observability/Metrics
>            Reporter: Dmitry Konstantinov
>            Assignee: Dmitry Konstantinov
>            Priority: Normal
>             Fix For: 6.x, 7.x
>
>         Attachments: image-2026-05-23-16-36-52-381.png
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> There are several places where we use LongAdder for metric purposes, it is 
> 0.9% CPU usage in total.
> We can replace it with ThreadLocalCounter to reduce overheads.
> Places:
> * org.apache.cassandra.io.sstable.keycache.KeyCache (hits and requests 
> counters)
> * org.apache.cassandra.io.sstable.filter.BloomFilterTracker
> * org.apache.cassandra.utils.memory.BufferPool#memoryInUse
> * org.apache.cassandra.transport.ServerConnection#requests (used by 
> Dispatcher on every request)
>  !image-2026-05-23-16-36-52-381.png|width=600! 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to