rustyrazorblade commented on code in PR #212:
URL:
https://github.com/apache/cassandra-analytics/pull/212#discussion_r3319001046
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/transports/storage/StorageAccessConfiguration.java:
##########
@@ -109,16 +111,22 @@ public void write(Kryo kryo, Output out,
StorageAccessConfiguration object)
{
out.writeString(object.region);
out.writeString(object.bucket);
- kryo.writeObject(out, object.storageCredentials);
+ boolean isIam = object.storageAuth instanceof IamStorageAuth;
+ out.writeBoolean(isIam);
+ if (!isIam)
Review Comment:
I misread your original comment, I addressed what you actually said.
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/transports/storage/StorageAccessConfiguration.java:
##########
@@ -109,16 +111,22 @@ public void write(Kryo kryo, Output out,
StorageAccessConfiguration object)
{
out.writeString(object.region);
out.writeString(object.bucket);
- kryo.writeObject(out, object.storageCredentials);
+ boolean isIam = object.storageAuth instanceof IamStorageAuth;
+ out.writeBoolean(isIam);
+ if (!isIam)
Review Comment:
I misread your original comment, I addressed what you actually said in code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
