[
https://issues.apache.org/jira/browse/CASSANDRA-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167584#comment-13167584
]
paul cannon commented on CASSANDRA-3101:
----------------------------------------
Vijay- I meant that the "fsutil hardlink create" command (which is already in
the code) looks like the right one to use in all cases except Windows XP, but
since we don't have a good way to verify, we might as well leave that part
alone.
Let's just get rid of the unused imports and add the extra logger.error() call.
> Should check for errors when calling /bin/ln
> --------------------------------------------
>
> Key: CASSANDRA-3101
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3101
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Reporter: paul cannon
> Assignee: Vijay
> Priority: Minor
> Labels: lhf
> Fix For: 1.0.6
>
> Attachments: 0001-3101-throw-IOE-while-calling-bin-ln.patch
>
>
> It looks like cassandra.utils.CLibrary.createHardLinkWithExec() does not
> check for any errors in the execution of the hard-link-making utility. This
> could be bad if, for example, the user has put the snapshot directory on a
> different filesystem from the data directory. The hard linking would fail and
> the sstable snapshots would not exist, but no error would be reported.
> It does look like errors with the more direct JNA link() call are handled
> correctly- an exception is thrown. The WithExec version should probably do
> the same thing.
> Definitely it would be enough to check the process exit value from /bin/ln
> for nonzero in the *nix case, but I don't know whether 'fsutil hardlink
> create' or 'cmd /c mklink /H' return nonzero on failure.
> For bonus points, use any output from the Process's error stream in the text
> of the exception, to aid in debugging problems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
