[
https://issues.apache.org/jira/browse/CASSANDRA-21474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18107373#comment-18107373
]
Stefan Miklosovic edited comment on CASSANDRA-21474 at 8/24/26 12:31 PM:
-------------------------------------------------------------------------
The CI looks very bad (1) but it is basically because of this:
{code}
Bad threads found:
NoSpamLogger:1
-Tools should not start threads that initialize singletons or other system
resources
{code}
[~viktoriiakotovets] I think we need to address this somehow ...
Does it make sense to have Caffeine cache only when running in daemon's context
and not when tools are run? In case we run tools then we would fallback to the
old way of doing things.
[~mck] [~brandon.williams] wdyt?
(1) https://pre-ci.cassandra.apache.org/job/cassandra/684/
was (Author: smiklosovic):
The CI looks very bad (1) but it is basically because of this:
{code}
Bad threads found:
NoSpamLogger:1
-Tools should not start threads that initialize singletons or other system
resources
{code}
[~viktoriiakotovets] I think we need to address this somehow ...
(1) https://pre-ci.cassandra.apache.org/job/cassandra/684/
> NoSpamLogger uses unbounded cache that could lead to memory exhaustion
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-21474
> URL: https://issues.apache.org/jira/browse/CASSANDRA-21474
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Observability/Logging
> Reporter: Kathiresan Selvaraj
> Assignee: Viktoriia Kotovets
> Priority: Normal
> Fix For: 6.x, 7.x
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> The {{NoSpamLogger}} class maintains an unbounded cache of log statement keys
> without any eviction policy, which poses a memory leak risk.
> * Unbounded cache growth: The {{lastMessage}} map in {{NoSpamLogger.java}}
> uses a {{NonBlockingHashMap}} with no size limit or eviction policy.
> * When log messages contain dynamic content (e.g., query strings in
> tombstone warnings), each unique message creates a new cache entry.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
