This is an automated email from the ASF dual-hosted git repository.
frankgh pushed a commit to branch cep-45-mutation-tracking
in repository https://gitbox.apache.org/repos/asf/cassandra.git
The following commit(s) were added to refs/heads/cep-45-mutation-tracking by
this push:
new 5e7cbad37d ninja: correct comment in CassandraStreamManager about what
the predicate for keyspace ranges does and add a note in
StreamSession#prepareAsync noting that the reconciledKeyspaceOffsets are
always null when the stream requests are being processed
5e7cbad37d is described below
commit 5e7cbad37d247e88f0ecfd0f6125062cb9c75930
Author: Francisco Guerrero <[email protected]>
AuthorDate: Fri Aug 21 16:45:03 2026 -0700
ninja: correct comment in CassandraStreamManager about what the predicate
for keyspace ranges does
and add a note in StreamSession#prepareAsync noting that the
reconciledKeyspaceOffsets are
always null when the stream requests are being processed
---
.../org/apache/cassandra/db/streaming/CassandraStreamManager.java | 2 +-
src/java/org/apache/cassandra/streaming/StreamSession.java | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git
a/src/java/org/apache/cassandra/db/streaming/CassandraStreamManager.java
b/src/java/org/apache/cassandra/db/streaming/CassandraStreamManager.java
index fee5075492..f8efbbc3a5 100644
--- a/src/java/org/apache/cassandra/db/streaming/CassandraStreamManager.java
+++ b/src/java/org/apache/cassandra/db/streaming/CassandraStreamManager.java
@@ -132,7 +132,7 @@ public class CassandraStreamManager implements
TableStreamManager
SSTableIntervalTree intervalTree =
buildSSTableIntervalTree(ImmutableList.copyOf(view.select(SSTableSet.CANONICAL)));
Predicate<SSTableReader> predicate;
// reconciledKeyspaceOffsets are only included when mutation
logs are streamed, since we include logs
- // for all unreconciled mutations, and SSTables for all
reconciled mutations
+ // for all unreconciled mutations, and exclude SSTables once
they are repaired or fully reconciled
if (reconciledKeyspaceOffsets != null)
{
Preconditions.checkArgument(previewKind ==
PreviewKind.NONE);
diff --git a/src/java/org/apache/cassandra/streaming/StreamSession.java
b/src/java/org/apache/cassandra/streaming/StreamSession.java
index 941b295687..83b5b619c6 100644
--- a/src/java/org/apache/cassandra/streaming/StreamSession.java
+++ b/src/java/org/apache/cassandra/streaming/StreamSession.java
@@ -901,6 +901,10 @@ public class StreamSession
{
if (StreamOperation.REPAIR == streamOperation())
checkAvailableDiskSpaceAndCompactions(summaries);
+ // process stream requests will not process any
reconciledKeyspaceOffsets
+ // when adding transfer ranges, this is because
reconciledKeyspaceOffsets
+ // only is assigned during prepareLogTransferring (a few methods down).
+ // We need to figure out whether this needs to be wired up in the
future.
processStreamRequests(requests);
for (StreamSummary summary : summaries)
prepareReceiving(summary);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
