[
https://issues.apache.org/jira/browse/CASSANDRA-21635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18111092#comment-18111092
]
Jeremiah Jordan commented on CASSANDRA-21635:
---------------------------------------------
[~maedhroz] Sorry, I just got to look at this today. The change looks good,
just one nit from me that might be good to update, the CHANGES.txt entry does
not mention reverse? Also I think this fixes inet type as well, not just
bigint? I think it would be good to mention the reverse part and the user type
names, bigint/inet in the CHANGES.txt entry given those are what an end user
would look for.
> IndexTermType#comparator() Handles Reversed Types Incorrectly
> -------------------------------------------------------------
>
> Key: CASSANDRA-21635
> URL: https://issues.apache.org/jira/browse/CASSANDRA-21635
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Feature/SAI
> Reporter: Caleb Rackliffe
> Assignee: Caleb Rackliffe
> Priority: Normal
> Fix For: 5.0.10, 6.0-alpha3, 7.x
>
> Attachments: ci_summary-2.html, ci_summary-3.html, ci_summary.html,
> result_details.tar-1.gz, result_details.tar-2.gz, result_details.tar.gz
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> {{IndexTermType#comparator()}} has only one caller in {{V1SSTableIndex}}.
> It's used there to establish the min and max terms across segments.
> Unfortunately, {{comparator()}} does not unwrap reversed clustering keys like
> {{compare()}} does, and with incorrect min/max, queries will miss data.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
