sarankk commented on code in PR #238:
URL:
https://github.com/apache/cassandra-analytics/pull/238#discussion_r4107623057
##########
cassandra-six-zero-types/src/main/java/org/apache/cassandra/bridge/SchemaUpdater.java:
##########
@@ -72,6 +72,27 @@ public static void openKeyspaceInstances()
ClusterMetadata.current().schema.initializeKeyspaceInstances(DistributedSchema.empty(),
false);
}
+ /**
+ * Creates the keyspace instance for one keyspace, leaving every other
keyspace's instance untouched.
+ *
+ * <p>Prefer this to {@link #openKeyspaceInstances()} whenever the caller
knows which keyspace is missing its
+ * instance. That method diffs against {@link DistributedSchema#empty()},
so every keyspace in the process looks
+ * newly created and all of them are rebuilt. Rebuilding a keyspace that
already has an instance constructs its
Review Comment:
Nice find! since the code path exists in trunk, can you fix it in trunk
first with a separate JIRA? also curious why trunk CI is not timing out with
the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
