[
https://issues.apache.org/jira/browse/CASSANDRA-21721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francisco Guerrero updated CASSANDRA-21721:
-------------------------------------------
Status: Ready to Commit (was: Review In Progress)
> Tighten up NoSpamLogger changes after migration to Caffeine cache
> -----------------------------------------------------------------
>
> Key: CASSANDRA-21721
> URL: https://issues.apache.org/jira/browse/CASSANDRA-21721
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Observability/Logging
> Reporter: Francisco Guerrero
> Assignee: Francisco Guerrero
> Priority: Normal
> Fix For: 6.0-alpha3, 7.0
>
> Attachments: CASSANDRA-21721-cassandra-6.0-ci_summary.html,
> CASSANDRA-21721-trunk-ci_summary.html
>
>
> After CASSANDRA-21474, the {{NoSpamLogger}} is now backed by a Caffeine cache
> instead of an unbounded cache. However, the ticker instance does not use the
> {{Clock}}'s instance. This ticket follows up on CASSANDRA-21474 to address
> the following :
> 1. The cache ticker reads real wall-clock time, bypassing Clock.Global
> 2. {{max_statements_per_logger}} is parsed per created instance, and 0
> disables rate limiting.
> 3. {{recordStats()}} costs on hot paths and is never read
> The patch will address item 1 by using {{Clock.Global}}. For 2, we parse the
> configuration value one, ensuring the rate limiting is not disabled. And for
> 3, we just remove {{recordStats}} since it's not being used anywhere.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
