yifan-c commented on code in PR #226: URL: https://github.com/apache/cassandra-analytics/pull/226#discussion_r4264510245
########## cassandra-analytics-common/src/test/java/org/apache/cassandra/spark/data/QualifiedTableNameTest.java: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.cassandra.spark.data; + +import org.junit.jupiter.api.Test; + +import static org.assertj.core.api.Assertions.assertThat; + +class QualifiedTableNameTest Review Comment: I'm ok with keeping those tests. `QualifiedTableName` is straightforward, but those unit test cases do not harm. ########## cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/data/CassandraDataLayerTests.java: ########## @@ -36,6 +49,35 @@ class CassandraDataLayerTests "table", "customers", "sidecar_contact_points", "localhost"); + @Test + void testDynamicSizingUsesRawIdentifiers() Review Comment: These two tests (`testDynamicSizingUsesRawIdentifiers` and `testSchemaUsesQuotedKeyspaceAndTokenRangesUseRawKeyspace`) only check that a mocked SidecarClient received certain argument strings. They don't verify how Sidecar handles those names, and they cover code this PR doesn't change (tokenRangeReplicas and sizing), so they pass with or without the fix. I'd drop them. An in-JVM dtest that runs cloud-storage transport against a mixed-case keyspace would be a better guard. That's out of scope here, so let's drop the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
