[ 
https://issues.apache.org/jira/browse/CASSANDRA-21812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18132594#comment-18132594
 ] 

Dmitry Konstantinov commented on CASSANDRA-21812:
-------------------------------------------------

+1

> Remove ArgGroup usage from nodetool commands
> --------------------------------------------
>
>                 Key: CASSANDRA-21812
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-21812
>             Project: Apache Cassandra
>          Issue Type: Task
>          Components: Tool/nodetool
>            Reporter: Maxim Muzafarov
>            Assignee: Maxim Muzafarov
>            Priority: Normal
>             Fix For: 6.0.x, 7.x
>
>
> {{nodetool cms dump}} is the only nodetool command that uses picocli's 
> {{@ArgGroup.}}
> Nodetool commands validate their options in the command body, and throw 
> IllegalArgumentException for it. This is an established pattern of the 
> argument validation in the code base.
> Moving it to an in-body check makes validation consistent across commands and 
> limits them to plain options and parameters, so CEP-38 can reuse nodetool 
> commands without supporting argument groups.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to