[
https://issues.apache.org/jira/browse/CASSANDRA-21812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-21812:
----------------------------------------
Source Control Link:
https://github.com/apache/cassandra/commit/54eb7f556765ba614737bc2dfc3d9210d0e9a9fc
Resolution: Fixed
Status: Resolved (was: Ready to Commit)
Committed to 6.0 and trunk
[~dnk] thank you for the review!
> Remove ArgGroup usage from nodetool commands
> --------------------------------------------
>
> Key: CASSANDRA-21812
> URL: https://issues.apache.org/jira/browse/CASSANDRA-21812
> Project: Apache Cassandra
> Issue Type: Task
> Components: Tool/nodetool
> Reporter: Maxim Muzafarov
> Assignee: Maxim Muzafarov
> Priority: Normal
> Fix For: 6.0.x, 7.x
>
> Attachments: ci_summary.html
>
>
> {{nodetool cms dump}} is the only nodetool command that uses picocli's
> {{@ArgGroup.}}
> Nodetool commands validate their options in the command body, and throw
> IllegalArgumentException for it. This is an established pattern of the
> argument validation in the code base.
> Moving it to an in-body check makes validation consistent across commands and
> limits them to plain options and parameters, so CEP-38 can reuse nodetool
> commands without supporting argument groups.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
