lukasz-antoniak commented on code in PR #254:
URL:
https://github.com/apache/cassandra-analytics/pull/254#discussion_r4424465198
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/DataLayer.java:
##########
@@ -267,13 +274,24 @@ public boolean useIncrementalRepair()
return true;
}
+ public boolean saiFilteringEnabled()
+ {
+ return ClientConfig.DEFAULT_SAI_FILTERING_ENABLED;
+ }
+
+ public int saiMaxCandidateTokens()
+ {
+ return ClientConfig.DEFAULT_SAI_MAX_CANDIDATE_TOKENS;
+ }
+
/**
* @return CompactionScanner for iterating over one or more SSTables,
compacting data and purging tombstones
*/
public StreamScanner<RowData> openCompactionScanner(int partitionId,
List<PartitionKeyFilter> partitionKeyFilters,
SSTableTimeRangeFilter
sstableTimeRangeFilter,
- @Nullable
PruneColumnFilter columnFilter)
+ @Nullable
PruneColumnFilter columnFilter,
+ @NotNull
List<SaiFilter> saiFilters)
Review Comment:
Will add a line in `CHANGES.txt`, but those interfaces were treated as
project-internal. Do you know of any other projects that uses them? We did
change the number of arguments in the past.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
