[ 
https://issues.apache.org/jira/browse/CASSANDRA-21740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18137870#comment-18137870
 ] 

Stefan Miklosovic commented on CASSANDRA-21740:
-----------------------------------------------

[CASSANDRA-21740-6.0|https://github.com/instaclustr/cassandra/tree/CASSANDRA-21740-6.0]
{noformat}
java11_pre-commit_tests                         
  ✓ j11_build                                        8m 16s
  ✓ j11_unit_tests_repeat                            7m 20s
  ✓ j11_utests_latest_repeat                         9m 34s
  ✓ j11_cqlsh_dtests_py38                             8m 0s
  ✓ j11_dtests                                       45m 0s
  ✓ j17_dtests_latest                               45m 24s
  ✓ j11_dtests_latest                               48m 44s
  ✓ j11_cqlshlib_cython_tests                       10m 58s
  ✓ j11_utests_oa_repeat                             6m 38s
  ✓ j17_utests_oa_repeat                             5m 30s
  ✓ j11_utests_latest                               23m 34s
  ✓ j11_unit_tests                                  23m 45s
  ✓ j17_cqlsh_dtests_py311_vnode                     8m 31s
  ✓ j11_cqlsh_dtests_py38_vnode                      9m 17s
  ✓ j17_cqlshlib_tests                              10m 37s
  ✓ j17_cqlsh_dtests_py38                            7m 40s
  ✓ j11_utests_system_keyspace_directory            24m 46s
  ✓ j11_dtests_vnode                                 50m 3s
  ✓ j17_utests_latest                               20m 57s
  ✓ j17_cqlsh_dtests_py38_vnode                      7m 32s
  ✓ j17_dtests_vnode                                43m 11s
  ✓ j11_utests_system_keyspace_directory_repeat       6m 4s
  ✓ j17_cqlsh_dtests_py311                            8m 4s
  ✓ j17_utests_oa                                   22m 20s
  ✓ j11_utests_oa                                   26m 17s
  ✓ j17_utests_latest_repeat                         5m 53s
  ✓ j17_unit_tests_repeat                            5m 55s
  ✓ j11_cqlshlib_tests                              10m 41s
  ✕ j17_jvm_dtests_latest_vnode                     43m 41s
      org.apache.cassandra.distributed.test.tcm.LostCommitReqResTest 
lostMoveCommitResponseTest
      org.apache.cassandra.distributed.test.tcm.LostCommitReqResTest 
lostMoveCommitRequestTest
      org.apache.cassandra.distributed.test.cql3.MultiNodeTokenConflictTest test
      
org.apache.cassandra.distributed.test.tcm.RemoteCmsCommitTimeoutDifferentiationTest
 moveUsesAdminTimeout
      
org.apache.cassandra.distributed.test.streaming.IndexBuildFailsAfterStreamingTest
 test
      junit.framework.TestSuite 
org.apache.cassandra.distributed.test.accord.AccordMigrationTest
      junit.framework.TestSuite 
org.apache.cassandra.distributed.test.accord.AccordMigrationTest
      org.apache.cassandra.distributed.test.CompactionStrategyOverrideTest 
testCompactionStrategyOverrideOnRestart
      org.apache.cassandra.distributed.test.sai.IndexHintsDistributedTest 
testIndexHintsWithAllOldVersion
      org.apache.cassandra.fuzz.topology.AccordTopologyMixupTest test
      
org.apache.cassandra.distributed.test.cql3.MixedReadsAccordInteropMultiNodeTokenConflictTest
 test
      org.apache.cassandra.fuzz.topology.IdenticalTopologyTest 
identicalTopologyTest TIMEOUTED
  ✕ j11_simulator_dtests                           1h 0m 3s
  ✕ j11_jvm_dtests                                  45m 35s
      org.apache.cassandra.fuzz.topology.IdenticalTopologyTest 
identicalTopologyTest TIMEOUTED
  ✕ j17_jvm_dtests                                  44m 37s
      org.apache.cassandra.fuzz.topology.IdenticalTopologyTest 
identicalTopologyTest TIMEOUTED
  ✕ j17_dtests                                      42m 51s
  ✕ j11_cqlsh_dtests_py311                           1m 28s
  ✕ j17_cqlshlib_cython_tests                        12m 3s
  ✕ j17_unit_tests                                  23m 15s
      org.apache.cassandra.net.ConnectionTest testTimeout
  ✕ j11_cqlsh_dtests_py311_vnode                     1m 48s
  ✕ j11_jvm_dtests_latest_vnode                     43m 35s
      org.apache.cassandra.distributed.test.CASMultiDCTest 
testLocalSerialLocalCommit
      org.apache.cassandra.distributed.test.tcm.LostCommitReqResTest 
lostMoveCommitResponseTest
      org.apache.cassandra.distributed.test.tcm.LostCommitReqResTest 
lostMoveCommitRequestTest
      
org.apache.cassandra.distributed.test.tcm.RemoteCmsCommitTimeoutDifferentiationTest
 moveUsesAdminTimeout
      
org.apache.cassandra.distributed.test.streaming.IndexBuildFailsAfterStreamingTest
 test
      junit.framework.TestSuite 
org.apache.cassandra.distributed.test.accord.AccordMigrationTest
      junit.framework.TestSuite 
org.apache.cassandra.distributed.test.accord.AccordMigrationTest
      org.apache.cassandra.distributed.test.CompactionStrategyOverrideTest 
testCompactionStrategyOverrideOnRestart
      org.apache.cassandra.distributed.test.sai.IndexHintsDistributedTest 
testIndexHintsWithAllOldVersion
      junit.framework.TestSuite 
org.apache.cassandra.distributed.test.repair.AutoRepairSchedulerTest
      org.apache.cassandra.fuzz.topology.IdenticalTopologyTest 
identicalTopologyTest TIMEOUTED
{noformat}

[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/6898/workflows/b669171f-f314-489b-9f3a-04616b4a9305]


> Prepared statement metadata reports a bind marker in a NOT IN restriction on 
> the partition key as a partition key bind index
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-21740
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-21740
>             Project: Apache Cassandra
>          Issue Type: Bug
>          Components: Feature/Prepared Statements
>            Reporter: Nadav Har'El
>            Assignee: Dipankar Achinta
>            Priority: Normal
>             Fix For: 4.0.x, 4.1.x, 5.0.x, 6.x, 7.x
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> In Cassandra 6.0-alpha2, preparing a query with a {{NOT IN}} restriction on 
> the partition key returns metadata that lists the {{NOT IN}} bind marker 
> among the partition key bind indexes (the "pk_indexes" of the PREPARED 
> result), as if it were a value of the partition key:
> {code:sql}
> CREATE TABLE ks.t (k int, i int, j int, PRIMARY KEY (k, i, j));
> -- prepare:
> SELECT * FROM ks.t WHERE k NOT IN (?) ALLOW FILTERING;      -- pk_indexes = 
> [0]
> SELECT * FROM ks.t WHERE k NOT IN (?, ?) ALLOW FILTERING;   -- pk_indexes = 
> [1]
> -- for comparison:
> SELECT * FROM ks.t WHERE k NOT IN ? ALLOW FILTERING;        -- no pk_indexes
> SELECT * FROM ks.t WHERE k = ?;                             -- pk_indexes = 
> [0]
> {code}
> A value in {{NOT IN}} is a partition key that the query excludes, so it 
> cannot be used to route the request. With this metadata, token-aware drivers 
> send the request to the replicas of the excluded key. Drivers may also refuse 
> to execute the request; for example, the Python driver fails to bind 
> {{UNSET_VALUE}} to the marker with "ValueError: Cannot bind UNSET_VALUE as a 
> part of the routing key 'k'". Because of this, the new {{NOT IN}} checks in 
> {{SelectSingleColumnRelationTest.testWithUnsetValues}} ({{k NOT IN(?)}} and 
> {{k NOT IN(?,?)}} with {{unset()}}) cannot be run through a driver. CQLTester 
> doesn't use a driver, so the Java test doesn't notice.
> {{NOT IN}} on the partition key was added in CASSANDRA-18584, so this affects 
> only Cassandra 6. Tested on 6.0-alpha2.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to