[ https://issues.apache.org/jira/browse/CASSANDRA-3688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178751#comment-13178751 ]
Sylvain Lebresne commented on CASSANDRA-3688: --------------------------------------------- I have nothing against that per se, but it's really in non-performance sensitive code and so doesn't matter at all. And the replacement is slightly more verbose. Overall I don't really care one way or the other but it does look like change for the sake of change, which we probably should avoid. > [patch] avoid map lookups in loops by using entrysets > ----------------------------------------------------- > > Key: CASSANDRA-3688 > URL: https://issues.apache.org/jira/browse/CASSANDRA-3688 > Project: Cassandra > Issue Type: Improvement > Components: Core > Affects Versions: 1.0.6 > Reporter: Dave Brosius > Priority: Trivial > Fix For: 1.0.7 > > Attachments: use_entrysets.diff > > > code loops over the keySet and does gets for the value, just use entrySet() -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira