[ https://issues.apache.org/jira/browse/CASSANDRA-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187285#comment-13187285 ]
Jonathan Ellis commented on CASSANDRA-3716: ------------------------------------------- There's still an awful lot of isMarkedForDelete calls there. I'm worried that it will be easy to inadvertently add incorrect uses of iMFD, and we'll miss it on audit b/c of the volume of calls to it. Any ideas on reducing that danger? > Clean up isMarkedForDelete / getLocalDeletionTime > ------------------------------------------------- > > Key: CASSANDRA-3716 > URL: https://issues.apache.org/jira/browse/CASSANDRA-3716 > Project: Cassandra > Issue Type: Improvement > Components: Core > Reporter: Jonathan Ellis > Assignee: Sylvain Lebresne > Labels: compaction > Fix For: 1.1 > > Attachments: 3716.patch > > > As explained in CASSANDRA-3579, isMarkedForDelete() depends on the current > system clock so it can change during a two-pass compaction. Suggested fix is > to replace iMFD + gLDT with a getExpirationTime method, so comparison with > the compaction's gcBefore will remain constant. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira