[ https://issues.apache.org/jira/browse/CASSANDRA-3735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200666#comment-13200666 ]
Peter Schuller commented on CASSANDRA-3735: ------------------------------------------- Correction, the conversion to post-2794 did remove the failure of the SSTableReaderTest. Or at least it's no longer happening for me on trunk with the attached patch (v2). Likely because it's only removing specific sstable components given by the iterator, rather than trying to recursively delete backups, but I don't pretend to understand exactly what the history of changes is that caused it to start failing to delete it to begin with. With repsect to the 'Largest generation seen...' warning, I get that too, but I don't see any subsequent hard link creation failures, nor do I understand why I would if the files are created without using the counter and the quick fix just suppresses the warning? But I'm probably missing something. I do have failing hard linking in ThriftValidationTest though. Maybe this is a side-effect that you're referring to? In any case, attaching the trivial (if I understood the suggestion correctly) reset patch that supresses the warning. > Fix "Unable to create hard link" SSTableReaderTest error messages > ----------------------------------------------------------------- > > Key: CASSANDRA-3735 > URL: https://issues.apache.org/jira/browse/CASSANDRA-3735 > Project: Cassandra > Issue Type: Bug > Reporter: Jonathan Ellis > Assignee: Jonathan Ellis > Priority: Minor > Attachments: 0001-fix-generation-update-in-loadNewSSTables.patch, > 0002-remove-incremental-backups-before-reloading-sstables-v2.patch, > 0002-remove-incremental-backups-before-reloading-sstables.patch, > 0003-reset-file-index-generator-on-reset.patch > > > Sample failure (on Windows): > {noformat} > [junit] java.io.IOException: Exception while executing the command: cmd > /c mklink /H > C:\Users\Jonathan\projects\cassandra\git\build\test\cassandra\data\Keyspace1\backups\Standard1-hc-1-Index.db > > c:\Users\Jonathan\projects\cassandra\git\build\test\cassandra\data\Keyspace1\Standard1-hc-1-Index.db,command > error Code: 1, command output: Cannot create a file when that file already > exists. > [junit] > [junit] at org.apache.cassandra.utils.CLibrary.exec(CLibrary.java:213) > [junit] at > org.apache.cassandra.utils.CLibrary.createHardLinkWithExec(CLibrary.java:188) > [junit] at > org.apache.cassandra.utils.CLibrary.createHardLink(CLibrary.java:151) > [junit] at > org.apache.cassandra.io.sstable.SSTableReader.createLinks(SSTableReader.java:833) > [junit] at > org.apache.cassandra.db.DataTracker$1.runMayThrow(DataTracker.java:161) > [junit] at > org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:30) > [junit] at > java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441) > [junit] at > java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) > [junit] at java.util.concurrent.FutureTask.run(FutureTask.java:138) > [junit] at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:98) > [junit] at > java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:206) > [junit] at > java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) > [junit] at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) > [junit] at java.lang.Thread.run(Thread.java:662) > [junit] ERROR 17:10:17,111 Fatal exception in thread > Thread[NonPeriodicTasks:1,5,main] > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira