[ 
https://issues.apache.org/jira/browse/CASSANDRA-3869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203617#comment-13203617
 ] 

Jonathan Ellis commented on CASSANDRA-3869:
-------------------------------------------

bq. messagedigest uses ByteBuffer.get for these

Right, it uses the "destructive" get which is why we need the duplication.
                
> [patch] don't duplicate ByteBuffers when hashing
> ------------------------------------------------
>
>                 Key: CASSANDRA-3869
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3869
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Dave Brosius
>         Attachments: dont_dup_bb_for_hash.diff, dont_dup_bb_for_hash2.diff
>
>
> given how often hashing of ByteBuffers occurs, don't duplicate the ByteBuffer 
> when hashing. (trivial - as the byte array was never copied just the BB 
> wrapper -- but still).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to