[ 
https://issues.apache.org/jira/browse/CASSANDRA-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207470#comment-13207470
 ] 

Peter Schuller commented on CASSANDRA-3412:
-------------------------------------------

You're right, I forgot that the RF is per DC, so there is no guarantee that you 
can pick the "keyspace with the highest replication factor [in each dc]". One 
*could* auto-select ks if it turns out that there *is* such a keyspace (that 
has highest RF in each DC), but that's a pretty specific case and the code to 
do that is probably non-trivial since the replication options are part of the 
replication strategy.

How about this for a compromise:

* If there is only a single non-system keyspace, use that (and do the describe 
ring type of dance)
* If there are multiple keyspaces, leave the percentage undefined unless the 
user selects keyspace

The main problem I think is that it's not clear how to make the user realize 
why he's not getting ownership information.

Another possibility:

* Make {{nodetool ring}} *never* print ownership.
* Add {{nodetool ownership}} (or similar) to print ownership, but in this case 
it either always requires a ks, or requires a ks if > 1 non-system one.

It's a bigger change to 'nodetool ring', but on the other hand the breakage 
will be obvious to people. And when specifically using 'ownership' you are 
perhaps more likely to read the docs or accept that you need to select a key 
space.

Not sure...

                
> make nodetool ring ownership smarter
> ------------------------------------
>
>                 Key: CASSANDRA-3412
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3412
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jackson Chung
>            Assignee: Vijay
>            Priority: Minor
>
> just a thought.. the ownership info currently just look at the token and 
> calculate the % between nodes. It would be nice if it could do more, such as 
> discriminate nodes of each DC, replica set, etc. 
> ticket is open for suggestion...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to