[ https://issues.apache.org/jira/browse/CASSANDRA-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214627#comment-13214627 ]
Sylvain Lebresne commented on CASSANDRA-3884: --------------------------------------------- It seems to perfectly make sense to send only the new mutation rather the entire schema so I'm good with that and it does fix the distributed test. But I'm not sure I understand why. Since Migration.announce() was call after applying the mutation, the new changes just applied should be part of the entire schema read from SystemTable, shouldn't they? So why did we get a SchemaDisagreementException before? Also a few other remarks/nits/questions: * In MigrationHelper if withSchemaRecord is false the mutations will be null, and most function will return a list containing null. We should return an empty list instead or null (but in that last case, Migration.apply() should deal with null). Also MigrationHelper.dropColumnFamily() directly return null, so we should make it match whatever we do for the other method. * It's slightly more efficient to use Collections.singleton() than Arrays.asList with one element. * Why does the tests now need to start gossip? > Intermittent SchemaDisagreementException > ---------------------------------------- > > Key: CASSANDRA-3884 > URL: https://issues.apache.org/jira/browse/CASSANDRA-3884 > Project: Cassandra > Issue Type: Bug > Components: Core > Affects Versions: 1.1.0 > Environment: using ccm on ubuntu. > Reporter: Tyler Patterson > Assignee: Pavel Yaskevich > Fix For: 1.1.0 > > Attachments: CASSANDRA-3884.patch > > > Set up a cluster of two nodes (on cassandra-1.1), create some keyspaces and > column families, and then make several schema changes. Everything is being > done through only one of the nodes. About once every 10 times (on my setup) > I get a SchemaDisagreementException when creating and dropping keyspaces. > There is a dtest for this: schema_changes_test.py. If your environment > behaves like mine, you might need to run it 10 times to get the error. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira