[ 
https://issues.apache.org/jira/browse/CASSANDRA-3996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239995#comment-13239995
 ] 

Jonathan Ellis commented on CASSANDRA-3996:
-------------------------------------------

+1 on v2

I'm not necessarily against doing the rest of this refactor in another ticket, 
since -- and I think this is the goal -- it sets us up to do a merge of results 
from multiple indexes), but I'd like to see more comments describing the code 
organization for a relatively large change like that.  (From a quick look, it 
also looks like changing "return endOfData" to "resetState" is unnecessary -- I 
prefer the former since it makes it clear that once you get to this point in 
the code, the iterator is finished.)
                
> Keys index skips results
> ------------------------
>
>                 Key: CASSANDRA-3996
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3996
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>            Reporter: Dmitry Petrashko
>            Assignee: Pavel Yaskevich
>             Fix For: 1.1.0
>
>         Attachments: CASSANDRA-3996-v2.patch, CASSANDRA-3996.patch, 
> KeysSearcher_fix_and_refactor-v2.patch, KeysSearcher_fix_and_refactor.patch
>
>
> While scanning results page if range index meets result already seen in 
> previous result set it decreases columnsRead that causes next iteration to 
> treat columsRead<rowsPerQuery as if last page was not full and scan is done.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to