[
https://issues.apache.org/jira/browse/CASSANDRA-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuki Morishita updated CASSANDRA-3668:
--------------------------------------
Attachment: 3668-1.1-v2.txt
Attaching rebased and updated version.
bq. super("READ-" + socket.getRemoteSocketAddress());
is back in ITC.
bq. StreamInSession.isFinished handling is not thread safe, we should use an
AtomicBoolean and test-an-set it. However AbstractStreamSession.close() already
use the same trick to ensure closeInternal() is called only once, so maybe we
could just move the code to add the sstables and secondary indexes to
closeInternal.
What I wanted to do here is to prevent sending SESSION_FINISHED message
multiple times as well. So instead of put the code in closeInternal, I expose
isClosed AtomicBoolean properties as protected and use it in closeIfFiished.
bq. StreamInSession.setCurrentFile() is a no-op and should be removed.
This part of the code was confusing. PendingFiles in 'files' are set beginning
of stream session and never get updated unless we swap its content with the one
used in IncomingStreamReader. Instead of swapping content, I added
updateProgress method to explicitly update progress of pending files.
In addition, there is the problem in StreamOutSession that first stream in
session does not contain all pending files in its stream header when stream in
parallel. I fixed it by making copy of all pending files before beginning
stream. (StreamOutSession#begin)
> Performance of sstableloader is affected in 1.0.x
> -------------------------------------------------
>
> Key: CASSANDRA-3668
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3668
> Project: Cassandra
> Issue Type: Bug
> Components: API
> Affects Versions: 1.0.0
> Reporter: Manish Zope
> Assignee: Yuki Morishita
> Priority: Minor
> Labels: streaming
> Fix For: 1.1.1
>
> Attachments: 3668-1.1-v2.txt, 3668-1.1.txt,
> 3688-reply_before_closing_writer.txt, sstable-loader performance.txt
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> One of my colleague had reported the bug regarding the degraded performance
> of the sstable generator and sstable loader.
> ISSUE :- https://issues.apache.org/jira/browse/CASSANDRA-3589
> As stated in above issue generator performance is rectified but performance
> of the sstableloader is still an issue.
> 3589 is marked as duplicate of 3618.Both issues shows resolved status.But the
> problem with sstableloader still exists.
> So opening other issue so that sstbleloader problem should not go unnoticed.
> FYI : We have tested the generator part with the patch given in 3589.Its
> Working fine.
> Please let us know if you guys require further inputs from our side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
