[
https://issues.apache.org/jira/browse/CASSANDRA-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278204#comment-13278204
]
Jonathan Ellis edited comment on CASSANDRA-4233 at 5/17/12 8:22 PM:
--------------------------------------------------------------------
I think the status quo (and v1, which perpetuates it) are too fragile...
Exhibit A being this bug, and exhibit B being my reading of the code leading me
to believe that there was no way to disable LCS. Rather than try to prevent
setting max inappropriately, much more clear to have LCS ignore min/max
entirely, except via isCompactionDisabled. This is closer to how it "should"
be w/ min + max being STCS-specific options.
v4 rearranges background/maximal methods to continue allowing maximal to kick
off a compaction when autocompaction is disabled.
was (Author: jbellis):
I think the status quo (and v1, which perpetuates it) are too complex...
Exhibit A being my reading of the code leading me to believe that there was no
way to disable LCS. Much more clear to have LCS make clear that it doesn't deal
with min/max at all, except via isCompactionDisabled.
v4 rearranges background/maximal methods to continue allowing maximal to kick
off a compaction when autocompaction is disabled.
> overlapping sstables in leveled compaction strategy
> ---------------------------------------------------
>
> Key: CASSANDRA-4233
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4233
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Jonathan Ellis
> Assignee: Sylvain Lebresne
> Fix For: 1.1.1
>
> Attachments:
> 0001-Make-sure-Leveled-compaction-always-use-the-right-min-.txt,
> 4233-assert.txt, 4233-v2.txt, 4233-v3.txt, 4233-v4.txt, system.log.bz2
>
>
> CASSANDRA-4142 introduces test failures, that are caused by overlapping
> tables within a level, which Shouldn't Happen.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
