[ 
https://issues.apache.org/jira/browse/CASSANDRA-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278463#comment-13278463
 ] 

Vijay commented on CASSANDRA-3687:
----------------------------------

+10, one thing which i noticed was will it be better to remove (coz the 
localnode might not be in position 0).

{code}
if (handler.endpoints.size() == 1 && 
handler.endpoints.get(0).equals(FBUtilities.getBroadcastAddress())
{code}

and add it to 

{code}
for (InetAddress endpoint : handler.endpoints)
{
    if (endpoint.equals(FBUtilities.getBroadcastAddress())
    {
        logger.debug("reading data locally");
        StageManager.getStage(Stage.READ).execute(new 
LocalRangeSliceRunnable(nodeCmd, handler));
    }
{code}

similar to fetchRows?
                
> Local range scans are not run on the read stage
> -----------------------------------------------
>
>                 Key: CASSANDRA-3687
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3687
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 1.2
>
>
> Running directly on the client request/StorageProxy thread means we're now 
> allowing one range scan per thrift thread instead of one per read stage 
> thread [which may be more, or less, depending on thrift server mode], and it 
> bypasses the "drop hopeless requests" overcapacity protection built in there. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to