[
https://issues.apache.org/jira/browse/CASSANDRA-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281330#comment-13281330
]
Vijay commented on CASSANDRA-3885:
----------------------------------
Hi David,
Thanks for the patch, (Needs a rebase and sorry for the delay in responding)
1) We should not be hand editing generated code/ SliceRange by hand.
2) Can we avoid doing ranges = ranges.toArray(new SliceRange[ranges.size()]);
to avoid unnecessary copies
3) we should not create org.apache.cassandra.thrift.SliceRange inside of
SliceQueryFilter we might want to keep the dependency of the thrift outside of
the storage layer.
4) not sure about the caching the results... We can just validate it in the
thrift layer so users will send proper query (this reduces complexity and
comparison on reads)?
> Support multiple ranges in SliceQueryFilter
> -------------------------------------------
>
> Key: CASSANDRA-3885
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3885
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Vijay
> Fix For: 1.2
>
> Attachments: CASSANDRA-3885.patch
>
>
> This is logically a subtask of CASSANDRA-2710, but Jira doesn't allow
> sub-sub-tasks.
> We need to support multiple ranges in a SliceQueryFilter, and we want
> querying them to be efficient, i.e., one pass through the row to get all of
> the ranges, rather than one pass per range.
> Supercolumns are irrelevant since the goal is to replace them anyway. Ignore
> supercolumn-related code or rip it out, whichever is easier.
> This is ONLY dealing with the storage engine part, not the StorageProxy and
> Command intra-node messages or the Thrift or CQL client APIs. Thus, a unit
> test should be added to ColumnFamilyStoreTest to demonstrate that it works.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
