[ 
https://issues.apache.org/jira/browse/CASSANDRA-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290535#comment-13290535
 ] 

Jonathan Ellis commented on CASSANDRA-4150:
-------------------------------------------

bq. Lets say when we add the entry we have a ratio of 1.2 and when the entry is 
removed we will have the ratio of 1.1 then we will leak some space for cache 
utilization. So it will be better if this number doesn't change

I did some code diving into CLHM -- it looks like it annotates the cache entry 
with the weight-at-put-time, and uses that in remove or replace.  If so, I 
think MemoryMeter might be fine after all.

OTOH if the cache isn't churning maybe MemoryMeter is just fine the way it is.

I'm inclined to close this and just open a new ticket for updating to CLHM 1.3 
in 1.2 and including keys in our weights.  Thoughts?
                
> Allow larger cache capacities than 2GB
> --------------------------------------
>
>                 Key: CASSANDRA-4150
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4150
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1.0
>            Reporter: Vijay
>            Assignee: Vijay
>             Fix For: 1.1.1
>
>         Attachments: 0001-CASSANDRA-4139-v2.patch, 0001-CASSANDRA-4150.patch, 
> 0002-Use-EntryWeigher-for-HeapCache.patch, 
> 0002-add-bytes-written-metric-v2.patch, concurrentlinkedhashmap-lru-1.3.jar
>
>
> The problem is that capacity is a Integer which can maximum hold 2 GB,
> I will post a fix to CLHM in the mean time we might want to remove the 
> maximumWeightedCapacity code path (atleast for Serializing cache) and 
> implement it in our code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to