[ https://issues.apache.org/jira/browse/CASSANDRA-4357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397328#comment-13397328 ]
Vijay commented on CASSANDRA-4357: ---------------------------------- {quote} I don't follow, if you're assuming currentVersion why do you need to encode at all? {quote} Hi Jonathan, What i mean is that when we create a new Commit log segment, we can encode current Messaging Version (instead of choosing a separate versioning scheme). This will be useful while replaying commit logs after the upgrade (only for the startup after the upgrades). Example: During recovery the commit log version (encoded in the name) is 3 and the current version is 4. > Add Commitlog Versioning > ------------------------ > > Key: CASSANDRA-4357 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4357 > Project: Cassandra > Issue Type: Improvement > Components: Core > Affects Versions: 1.2 > Reporter: Vijay > Assignee: Vijay > Priority: Minor > Fix For: 1.2 > > > Currently when there are changes in protocol version in RowMutation it is not > handled in the Commit Logs. > CASSANDRA-4139 adds changes which exposes this. > It would be nice to reuse MessagingService.currentVersion to be the Commit > Log version (encoded in the name) instead of creating a separate one. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira