[ https://issues.apache.org/jira/browse/CASSANDRA-4299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402016#comment-13402016 ]
Sylvain Lebresne commented on CASSANDRA-4299: --------------------------------------------- I'm not really sure about this This really just add an additional pass over the columns that is not really useful per-se. My remark in CASSANDRA-3974 was that it would be great to have one and only one place where we delt with removed columns but this without doing any duplicate work. And with this patch, we deal with deleted columns in isRevelant and then in removeDeleted. To be clear, I am not saying I have a clear idea on how to achieve that and that might in fact not be so easy or even doable. > Update read paths to ensure ColumnFamilyStore.removeDeleted is called > --------------------------------------------------------------------- > > Key: CASSANDRA-4299 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4299 > Project: Cassandra > Issue Type: Bug > Components: Core > Affects Versions: 1.2 > Reporter: Kirk True > Assignee: Kirk True > Fix For: 1.2 > > Attachments: trunk-4299.txt > > > In some cases, {{RowIteratorFactory}}'s {{getReduced}} calls the > filter.collateColumns path and doesn't remove columns TTL-ed out (by > CASSANDRA-3974). > Sylvain suggested that we should put {{removeDeleted}} on every read path, > making it the only method concerned with tombstone and CF-TTL checks. He also > suggested that {{QueryFilter.isRelelevant}} might then be able to be removed. > See comments in CASSANDRA-3974 for more information. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira