[ 
https://issues.apache.org/jira/browse/CASSANDRA-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419967#comment-13419967
 ] 

Aleksey Yeschenko commented on CASSANDRA-2116:
----------------------------------------------

{quote}
CollationController needs to retain its try/catch, since we want to allow the 
read to succeed, even if the defragmenting write fails. Since it could error w/ 
either FSWE or EE (from the commitlog add), probably need to catch generic 
Exception. For 2118 we can add some way to submit this to the disk blacklister 
without re-throwing.
{quote}
Actually it can't throw - it skips both the commitlog write and the index 
update (it calls Table#apply(rm, false, false)). It's mentioned in the comment 
above the call. I think it's fine to leave out the try/catch.
                
> Separate out filesystem errors from generic IOErrors
> ----------------------------------------------------
>
>                 Key: CASSANDRA-2116
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2116
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Chris Goffinet
>            Assignee: Aleksey Yeschenko
>             Fix For: 1.2
>
>         Attachments: 
> 0001-Issue-2116-Replace-some-IOErrors-with-more-informati.patch, 
> 0001-Separate-out-filesystem-errors-from-generic-IOErrors.patch, 
> CASSANDRA-2116-v3.patch
>
>
> We throw IOErrors everywhere today in the codebase. We should separate out 
> specific errors such as (reading, writing) from filesystem into FSReadError 
> and FSWriteError. This makes it possible in the next ticket to allow certain 
> failure modes (kill the server if reads or writes fail to disk).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to