[
https://issues.apache.org/jira/browse/CASSANDRA-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Ellis updated CASSANDRA-2116:
--------------------------------------
Attachment: 2116-v5.txt
v5 attached. I got up through KeyIterator in the review but got bogged down in
the compressed reader code, which needs some deeper fixes. (Still lots of bare
IOExceptions being thrown in CM.Writer and CRAR.)
Here's the changes I made while going through it:
- updated try/catch in CCE.create to wrap the bytesRemaining call specifically
- moved StorageService.getCannonicalPath into FileUtils and added overload
taking a File
- updated CFMD.reload to turn ConfigurationException into RTE instead of IOE
- Introduced CorruptSSTableError where we were using RTE. We don't do anything
with it, yet, but this will make it much easier if we need to down the road
since RTE is used *all* over the place.
- added FSWE around setLength in CommitLogSegment
- removed extra catches in doCleanupCompaction in favor of the existing catch
(Exception) block, extended to Throwable
- split FailureDetector RTE into RTE + FSWE
- lots of changes to RandomAccessReader, CompressionMetadata, CRAR (incomplete)
> Separate out filesystem errors from generic IOErrors
> ----------------------------------------------------
>
> Key: CASSANDRA-2116
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2116
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Chris Goffinet
> Assignee: Aleksey Yeschenko
> Fix For: 1.2
>
> Attachments:
> 0001-Issue-2116-Replace-some-IOErrors-with-more-informati.patch,
> 0001-Separate-out-filesystem-errors-from-generic-IOErrors.patch, 2116-v5.txt,
> CASSANDRA-2116-v3.patch, CASSANDRA-2116-v4.patch
>
>
> We throw IOErrors everywhere today in the codebase. We should separate out
> specific errors such as (reading, writing) from filesystem into FSReadError
> and FSWriteError. This makes it possible in the next ticket to allow certain
> failure modes (kill the server if reads or writes fail to disk).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
