[ https://issues.apache.org/jira/browse/CASSANDRA-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422810#comment-13422810 ]
Dave Brosius commented on CASSANDRA-4460: ----------------------------------------- LGTM > SystemTable.setBootstrapState always sets bootstrap state to true > ----------------------------------------------------------------- > > Key: CASSANDRA-4460 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4460 > Project: Cassandra > Issue Type: Bug > Components: Core > Affects Versions: 1.2 > Reporter: Dave Brosius > Assignee: Dave Brosius > Priority: Trivial > Attachments: 4460.txt, use_bootstrap_enum_strings.txt > > > public static void setBootstrapState(BootstrapState state) > { > String req = "INSERT INTO system.%s (key, bootstrapped) VALUES ('%s', > '%b')"; > processInternal(String.format(req, LOCAL_CF, LOCAL_KEY, > getBootstrapState())); > forceBlockingFlush(LOCAL_CF); > } > Third parameter %b is set from getBootstrapState() which returns an enum, > thus %b collapses to null/non null checks. This would seem then to always set > it to true. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira