[ https://issues.apache.org/jira/browse/CASSANDRA-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424177#comment-13424177 ]
Jonathan Ellis commented on CASSANDRA-4427: ------------------------------------------- bq. I believe the schemaPresent condition shouldn't be negated Right, fix pushed to same github branch. bq. I would have put the initialization fo Schema.emptyVersion in a static block to make it explicit that it's a one time initialization I thought you couldn't declare emptyVersion final that way... I was wrong, the compiler is smart enough to recognize the static block. Also fixed. bq. it could be nice to also log whether we're going to boostrap or not and why in the other case. Added a debug line. bq. exclude ourselves when we check for schemaPresent Done. (Since we can't have one ourselves unless another does too -- or unless we already joined the ring successfully -- there is no loss of correctness.) bq. this feels a bit bigger than what I'm plainly confortable pushing in 1.0 at this point +1, let's leave it as a known issue in 1.0. > Restarting a failed bootstrap instajoins the ring > ------------------------------------------------- > > Key: CASSANDRA-4427 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4427 > Project: Cassandra > Issue Type: Bug > Components: Core > Affects Versions: 1.0.0 > Reporter: Brandon Williams > Assignee: Jonathan Ellis > Fix For: 1.1.3 > > Attachments: 4427-v2.txt, 4427-v3.txt, 4427.txt > > > I think when we made auto_bootstrap = true the default, we broke the check > for the bootstrap flag, creating a dangerous situation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira