[ 
https://issues.apache.org/jira/browse/CASSANDRA-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439712#comment-13439712
 ] 

Edward Capriolo commented on CASSANDRA-4565:
--------------------------------------------

Never mind means this does not need to be done.

The method called earlier in the flush process.     
cf.maybeResetDeletionTimes(gcBefore); 
converts ExpiredColumns past their grace into DeletedColumns and then they do 
not get flushed.

We could keep the test case if to be sure this functionality stays working.
Also the condition:
c.getLocalDeletionTime() < gcBefore

Makes no sense to me gcBefore is defined as Integer.MIN_VALUE so this condition 
looks like it can never be met.
                
> TTL columns with older then gcgrace do not need to flush
> --------------------------------------------------------
>
>                 Key: CASSANDRA-4565
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4565
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>             Fix For: 1.3
>
>         Attachments: cassandra-4565.patch.1.txt
>
>
> With memcache many people are willing to sacrifice durability for 
> performance. Cassandra has a TimeToLive feature that can be used in caching 
> scenarios with low values for gc_grace_seconds. However from a code dive it 
> seems that cassandra will always write TTL to disk, even those that are 
> beyond gc_grace_seconds. If a use case very large memtables,small ttl, and 
> small gc_grace it is possible that flushing these columns to disk can be 
> skipped entirely in some scenarios. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to