[ 
https://issues.apache.org/jira/browse/CASSANDRA-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469518#comment-13469518
 ] 

Sylvain Lebresne commented on CASSANDRA-4763:
---------------------------------------------

Just to add context, this was done initially because it was pretty hard to do 
otherwise due to the hard-coded way sstables names were parsed. This was 
changed in 1.1 however, so we should be able to do that easily now.
                
> SSTableLoader shouldn't get keyspace from path
> ----------------------------------------------
>
>                 Key: CASSANDRA-4763
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4763
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 1.2.0 beta 1
>            Reporter: Nick Bailey
>            Priority: Minor
>
> SSTableLoader currently gets the keyspace it is going to load to from the 
> path of the directoy of sstables it is loading. This isn't really documented 
> (or I didn't see it), but also isn't really a good way of doing it in general.
> {noformat}
> this.keyspace = directory.getParentFile().getName();
> {noformat}
> We should probably just let users pass the name in. If you are loading a 
> snapshot the file names will have the keyspace which is slightly better but 
> people manually creating their own sstables might not format them the same.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to