[ 
https://issues.apache.org/jira/browse/CASSANDRA-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488465#comment-13488465
 ] 

Vijay edited comment on CASSANDRA-4876 at 11/1/12 5:03 AM:
-----------------------------------------------------------

Looks like there is a bug in http://goo.gl/jPUe0, when getBloomFilterFpChance 
return 1.0 we might not store or use BF at all... it should have been > 0.01 
right? same with line #450 not sure i am misreading the patch.
                
      was (Author: vijay2...@yahoo.com):
    Looks like there is a bug in http://goo.gl/jPUe0, when 
getBloomFilterFpChance return 1.0 we might not store or use BF at all... it 
should have been > 0.01 right? same with getBloomFilterFpChance not sure i am 
misreading the patch.
                  
> Make bloom filters optional by default for LCS
> ----------------------------------------------
>
>                 Key: CASSANDRA-4876
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4876
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> Since LCS gives us only 10% chance we will need to merge data from multiple 
> sstables, bloom filters are a waste of memory (unless you have a workload 
> where you request lots of keys that don't exist).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to