[ 
https://issues.apache.org/jira/browse/CASSANDRA-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489211#comment-13489211
 ] 

Jonathan Ellis commented on CASSANDRA-4889:
-------------------------------------------

asserts are to validate preconditions and other assumptions made by the 
developer, which includes the check mentioned by Dave here.  Rewriting it as a 
unit test would be silly.
                
> Code cleanup against JDK 1.6 codestyle guide
> --------------------------------------------
>
>                 Key: CASSANDRA-4889
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4889
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Radim Kolar
>            Assignee: Radim Kolar
>            Priority: Minor
>              Labels: codestyle
>         Attachments: cass-cleanup1.txt, cass-cleanup2.txt
>
>
> Code cleanup against jdk1.6 ruleset on lowest settings.
> problems fixed:
> extra ;
> unused imports
> incorrect if (condition is always true or always false)
> using static variable in non static way
> always true asserts

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to