[ 
https://issues.apache.org/jira/browse/CASSANDRA-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495866#comment-13495866
 ] 

Jonathan Ellis commented on CASSANDRA-3017:
-------------------------------------------

We're mainly concerned about the insertion path here.  So I was thinking more 
along the lines of just comparing (by inspection) what MessageOut sends for a 
row of data, to the minimum for that with Thrift.  (No compression is 
involved.)  I think we only really have two scenarios to worry about:

# for an insert call of a single column, is MessageOut's overhead less than 
Thrift's?
# as we add more columns, does our per-column overhead grow faster?

We don't need to worry about batch_mutate or atomic_batch_mutate since those 
will be strictly higher-overhead than the equivalent insert calls.

                
> add a Message size limit
> ------------------------
>
>                 Key: CASSANDRA-3017
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3017
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Kirk True
>            Priority: Minor
>              Labels: lhf
>         Attachments: 
> 0001-use-the-thrift-max-message-size-for-inter-node-messa.patch, 
> trunk-3017.txt
>
>
> We protect the server from allocating huge buffers for malformed message with 
> the Thrift frame size (CASSANDRA-475).  But we don't have similar protection 
> for the inter-node Message objects.
> Adding this would be good to deal with malicious adversaries as well as a 
> malfunctioning cluster participant.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to