[ 
https://issues.apache.org/jira/browse/CASSANDRA-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

MichaƂ Michalski updated CASSANDRA-3378:
----------------------------------------

    Attachment: cassandra-3378-v1.patch

I've attached an initial patch. As I mentioned I had a little concern on what 
to do with the default buffer size that is set for BufferedOutputStream and why 
is it set only for uncompressed OutputStream. I've read CASSANDRA-1896 and I 
understand why it's set to 4096, but I can only guess why it's not set for 
compressed stream too. Anyway - I'm pretty sure that user settings should 
overwrite this default 4096, but I wonder if default of 4096 should stay in 
code (so default buffer size values for compressed and uncompressed streams are 
handled separately) or maybe it should be set by default in cassandra.yaml. 
However, second solution (which I picked for now) causes compressed output 
stream to have default buffer size of 4096 bytes too, so it leads back to my 
first concern: is this a behaviour we expect? 

Waiting for a comment and I'll improve this patch according to your suggestion.
                
> Allow configuration of storage protocol socket buffer
> -----------------------------------------------------
>
>                 Key: CASSANDRA-3378
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3378
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Brandon Williams
>            Priority: Minor
>              Labels: lhf
>         Attachments: cassandra-3378-v1.patch
>
>
> Similar to rpc_[send,recv]_buff_size_in_bytes, we should expose this for high 
> latency connections.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to