[ https://issues.apache.org/jira/browse/CASSANDRA-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540511#comment-13540511 ]
Yuki Morishita commented on CASSANDRA-5077: ------------------------------------------- Patch looks good, +1. > Simplify CompactionIterable.getReduced > -------------------------------------- > > Key: CASSANDRA-5077 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5077 > Project: Cassandra > Issue Type: Improvement > Reporter: Jonathan Ellis > Assignee: Jonathan Ellis > Fix For: 1.2.1 > > Attachments: 5077-close-writers.txt, 5077.txt, 5077.txt > > > CompactionIterable turns empty rows into null, and > purge-compacted-rows-from-cache logic is duplicated (and different!) across > implementations. Let's simplify to just return empty rows as-is and let > CompactionTask handle the purge logic. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira